fix: install generated manpages out of tree#955
Merged
tridge merged 1 commit intoJun 4, 2026
Conversation
Member
Author
|
NetBSD failure looks unrelated to this change. It fails during VM package setup before the rsync build/install path reaches the Makefile change whatsoever. |
tridge
force-pushed
the
fix-out-of-tree-manpage-install
branch
from
860fc16 to
dba4aef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #846 by installing generated manpages from the source directory when they are not present in an out-of-tree build directory.
Release tarballs include pre-generated manpages. With an out-of-tree build configured using
--disable-md2man,make installcould install the binaries but skip the manpages because the install rule only checked the build directory.This keeps the existing build-directory preference then falls back to
$(srcdir)forrsync.1,rsync-ssl.1,rsyncd.conf.5and the optionalrrsync.1.Tested with a v3.4.3 release tarball using:
../configure --disable-md2man --with-rrsyncmakemake install DESTDIR=...Before this change, the install tree missed the generated manpages. After this change,
rsync.1,rsync-ssl.1,rrsync.1andrsyncd.conf.5are installed.